RFR: 8252324: Signal related code should be shared among POSIX platforms [v5]
Gerard Ziemski
gziemski at openjdk.java.net
Fri Oct 2 17:05:56 UTC 2020
On Fri, 2 Oct 2020 03:49:44 GMT, David Holmes <dholmes at openjdk.org> wrote:
>>> merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your
>>> intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of
>>> this pull request to `Merge <project>:<branch>` where `<project>` is the name of another project in the [OpenJDK
>>> organization](https://github.com/openjdk) (for example `Merge jdk:master`).
>>
>> Can anyone explain what this means and whether it's OK to go ahead with this pr, or should I close this one (since I
>> made quite a mess of it) and start a new one?
>
> Hi Gerard,
>
> I'm afraid something is still very wrong here. I see you fixing the original merge issues in:
>
> b33d292e96a559b8a3a998641411f61bf087738f (Address David's review issues )
>
> but then the "Fix Merge" commit
>
> 4f5d4cd49436b64dc3770e4ba1f811a76b5a09e7
>
> applied after that seems to have reversed them again!
>
> I think it might be necessary to close this PR and create a new one.
>
> Thanks.
I'm considering this pr to be "lost cause", so I just "force pushed" to a known good state, wiping out the bad merge
that backed out my fixes based on David's comments, so that I have a snapshot of what I want to become the basis of new
pr.
Just thought I would explain what I'm trying to do before anyone points out to me that I should not be using
"push --force".
-------------
PR: https://git.openjdk.java.net/jdk/pull/157
More information about the hotspot-runtime-dev
mailing list