RFR: 8261479: CDS runtime code should check exceptions [v2]

Ioi Lam iklam at openjdk.java.net
Mon Mar 22 23:13:42 UTC 2021


On Mon, 22 Mar 2021 22:36:29 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> > I think this should also be be changed to a `CHECK`:
> > ```
> > void MetaspaceShared::post_initialize(TRAPS) {
> >   if (UseSharedSpaces) {
> >     int size = FileMapInfo::get_number_of_shared_paths();
> >     if (size > 0) {
> >       SystemDictionaryShared::allocate_shared_data_arrays(size, THREAD); <<<<
> > ```
> 
> It was already changed to a `CHECK` in the webrev:
> 
> ```
> 219     int size = FileMapInfo::get_number_of_shared_paths();
> 220     if (size > 0) {
> 221       SystemDictionaryShared::allocate_shared_data_arrays(size, CHECK);
> ```

Oh, you're right. Sorry I missed that :-(

-------------

PR: https://git.openjdk.java.net/jdk/pull/3097


More information about the hotspot-runtime-dev mailing list