RFR: 8267095: Miscellaneous cleanups in vm.runtime.defmeth tests [v2]

[Harold Seigel]

On Tue, 25 May 2021 22:06:45 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Miscellaneous refactorings/cleanups in `vm.runtime.defmeth` tests.
>> 
>> In particular: 
>>   - replace `test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/scenarios` with enumeration of different test configurations in tests themselves; 
>>   - pass `TestBuilder` as a parameter and initiate test execution from executor; 
>>   - switch max class file version tested from 52 to 61 (`V17`); 
>>   - minor changes (cleanups, new test cases)
>> 
>> Testing:
>> - [x] vmTestbase/vm/runtime/defmeth/
>> - [x] hs-tier5-rt - hs-tier8-rt
>
> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'master' into 8267095.defmeth
>  - Remove ACC_STRICT-related code
>  - Cleanup
>  - Remove scenarios
>  - FIXME removal
>  - Fixes
>  - TestBuilder as a parameter

This big cleanup looks good.  I just had the one comment below about class file versions.  Also, can you update the copyrights?
Thanks, Harold

test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/StressTest.java line 163:

> 161:             majorVerValues[i] = MIN_MAJOR_VER + i;
> 162:         }
> 163: 

Does this mean that the stress tests will run for all class versions between JDK 1.5 and JDK 17 ?  If so, maybe change it to just run for JDK 1.5, 11, and 17 releases?

-------------

Marked as reviewed by hseigel (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4008