RFR: 8271569: Clean up the use of CDS constants and field offsets [v6]

Yumin Qi minqi at openjdk.java.net
Tue Sep 14 21:55:05 UTC 2021


On Tue, 14 Sep 2021 06:23:20 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Is this even needed now? I don't see it being used.
>
> To be clear, the layout that I'd like to see is:
> 
> #include "precompiled.hpp"
> #include "cds.hpp"
> ...
> #include "cds/filemap.hpp"
> 
> #include <cstddef>
> 
> 
> However, I think the more appropriate change is to include globalDefinitions.hpp instead of explicitly including cstddef.

The pre-submit tests failed to build hotspot for linux on arm/ppc/s390 etc after <cstddef> removed. <cstddef> needed for defining size_t. So will add it back at last section of 'include'.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5450


More information about the hotspot-runtime-dev mailing list