RFR: 8271569: Clean up the use of CDS constants and field offsets [v7]

[Ioi Lam]

On Tue, 14 Sep 2021 21:52:04 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> To be clear, the layout that I'd like to see is:
>> 
>> #include "precompiled.hpp"
>> #include "cds.hpp"
>> ...
>> #include "cds/filemap.hpp"
>> 
>> #include <cstddef>
>> 
>> 
>> However, I think the more appropriate change is to include globalDefinitions.hpp instead of explicitly including cstddef.
>
> The pre-submit tests failed to build hotspot for linux on arm/ppc/s390 etc after <cstddef> removed. <cstddef> needed for defining size_t. So will add it back at last section of 'include'.

The problem is here in cdsConstants.hpp


#include "memory/allStatic.hpp"
typedef struct {
  const char* _name;
  size_t _value;
} CDSConst;


globalDefinitions.hpp should be included here for the declaration of `size_t`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5450