RFR: 8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern.

[Thomas Stuefe]

On Fri, 10 Mar 2023 09:33:10 GMT, Varada M <duke at openjdk.org> wrote:

> When last pattern in deque [positivePatternStack] is not matching in HsErrFile, it comes out of the loop and check whether the positivePatternStack is empty or not, which turns to be empty because the pollFirst() removes the pattern. 
> 
> This has been noticed in the TestSigInfoInHsErrFile.java where the segfault address for AIX is set as "0x0*1400" instead of "0xffffffffffffffff", which should throw the expected error but the error is neglected due to empty deque and the test is passed. 
> 
> JBS issue : [8303948](https://bugs.openjdk.org/browse/JDK-8303948)

@varada1110 Ouch, thank you for finding that. Let's see how many tests now start failing :-/

Could a slightly more elegant patch not be to change the condition after the loop not from

< if (!positivePatternStack.isEmpty()) {
> if (currentPositivePattern != nullptr) {

?

But I leave that up to you. Patch is also fine in its current form.

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12970