RFR: 8325456: Rename nsk_mutex.h

[Kim Barrett]

On Thu, 8 Feb 2024 14:05:03 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I just had a look at this and the way the file nsk/jvmti/scenarios/events/EM04/em04t001/libem04t001.cpp includes nsk_mutex.cpp is consistent with how it includes other cpp files so not worth changing (ie. deleting this) without more rewriting. The rename change looks good and is trivial.

Thanks for the review, @coleenp and @TheShermanTanker .

That seems to be a fairly common pattern in tests. There's a "library" source
file that gets compiled and linked. It directly includes all of the relevant
source files, rather than having those built separately and the relevant ones
linked together to make the library. It makes the build a bit simpler, since
there's less information in the makefiles.  It does mean we're potentially
compiling the same source repeatedly, but compilation is cheap...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17762#issuecomment-1934601518