RFR: 8313306: More sensible reservation logging [v10]

[Coleen Phillimore]

On Wed, 14 Feb 2024 06:48:21 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> +1 to fatal().
>> 
>>>Why does AIX have this?
>>>
>>>#define assert0(b) assert((b), "")
>>>#define guarantee0(b) guarantee((b), "")
>>>
>>>??
>> 
>> This is my code I think, from way back when we started the AIX port at SAP. Based on Suns licensed hotspot sources. I really disliked having to state a reason for the assert every time I wrote one, so I saved me work by adding the 0 variants. I kind of came to terms with the reason parameter now.
>> 
>> Note that was from a time where we could not give back coding upstream, so the AIX port has a number of constructs like this.
>
> But lets leave this for now; lets limit this PR to logging. Code overhaul of the AIX os layer can be done separately.

Thanks for the explanation of assert0 and guarantee0.  I generally find the reason parameter serves the same purpose as a comment except in some places where it's simply "sanity", but I get it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1489809645