RFR: JDK-8326496: [test] checkHsErrFileContent support printing hserr in error case [v2]

Matthias Baesken mbaesken at openjdk.org
Fri Feb 23 11:05:18 UTC 2024


On Fri, 23 Feb 2024 10:43:13 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add verbose param doc
>
> test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUtils.java line 66:
> 
>> 64:      * @param f Input file
>> 65:      * @param patterns An array of patterns that need to match, in that order
>> 66:      * @throws RuntimeException, {@link IOException}
> 
> The Javadoc of parameter "verbose" should not be removed here.

okay I added it again; but it was already not documented in the same way before my change, once "the matched patterns are printed" once "only important information are printed" . Should we adjust it and to what ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17978#discussion_r1500507877


More information about the hotspot-runtime-dev mailing list