RFR: 8323438: Enhance assertions for Windows sync API failures [v2]

David Holmes dholmes at openjdk.org
Mon Jan 22 04:16:51 UTC 2024


On Fri, 19 Jan 2024 05:55:28 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Looks good. Just couple of nits:

Thanks for looking at this  @calvinccheung !

>     * for clarity, should `GetLastError()` be `::GetLastError()`? (I saw both ways in the existing code)

There is no need, and many existing usages without the `::`.
 
>     * copyright year needs to be updated.

Fixed. Thanks

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17457#issuecomment-1903193611


More information about the hotspot-runtime-dev mailing list