RFR: 8350444: Check for verifer error in StackMapReader::check_offset() [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Feb 21 13:23:12 UTC 2025


On Thu, 20 Feb 2025 23:02:09 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This small patch adds error propagation in the newly added `check_offset()` method. Verified with tier 1-5 tests
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check for exception without TRAPS

I assume that the callers to next() check that the frame has an error, the only effect of not having a CHECK_VERIFY(return) is that _prev_frame is set and frame is returned but the error is checked by the caller and not the return value.  So I don't think there was an observable bug.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23717#pullrequestreview-2633024475


More information about the hotspot-runtime-dev mailing list