[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v4]

[Reka Kovacs]

On Mon, 4 Oct 2021 22:40:09 GMT, Reka Kovacs <github.com+25946952+rnkovacs at openjdk.org> wrote:

>> Main commit of the Windows/AArch64 port.
>> 
>> Also fixes [JDK-8272181](https://bugs.openjdk.java.net/browse/JDK-8272181) by adding [`src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp`](https://github.com/openjdk/jdk11u-dev/pull/301/files#diff-235302dc4618158c4f75771ebbb6f0e4beeee5daf0a537b03ee4253a711268c6), which is needed for a successful Windows-AArch64 build.
>> 
>> Depends on #274 and #299.
>
> Reka Kovacs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 9604ee82690f89320614b37bfef4178abc869777

Rebased on top of updated dependencies and removed redundant subtraction of scratch registers in `MacroAssembler::push_call_clobbered_registers()`.

I didn't do the `pusha()` part yet as I haven't seen any response to @lewurm's suggestion:

> > [...] where pusha is :
> > void MacroAssembler::pusha() { push(0x7fffffff, sp); }
> > [...]
> 
> Nice catch!
> 
> I'm not sure if this should go as part of this PR. The same problem exists in jdk-tip and therefore should be addressed there first: https://github.com/openjdk/jdk/blob/c05dc268acaf87236f30cf700ea3ac778e3b20e5/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L1859-L1865
> 
> On jdk-tip there is only one usage left in the template interpreter generator: https://github.com/openjdk/jdk/blob/c05dc268acaf87236f30cf700ea3ac778e3b20e5/src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp#L1400-L1404
> 
> Seems like the code path is uncommon, but we should still fix it imho.
> 
> What do you think?

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301