[jdk11u-dev] RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v4]

[Vladimir Kempik]

On Mon, 4 Oct 2021 22:45:48 GMT, Reka Kovacs <github.com+25946952+rnkovacs at openjdk.org> wrote:

> > [...] where pusha is :
> > void MacroAssembler::pusha() { push(0x7fffffff, sp); }
> > [...]
> 
> Nice catch!
> 
> I'm not sure if this should go as part of this PR. The same problem exists in jdk-tip and therefore should be addressed there first: https://github.com/openjdk/jdk/blob/c05dc268acaf87236f30cf700ea3ac778e3b20e5/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L1859-L1865
> 
> On jdk-tip there is only one usage left in the template interpreter generator: https://github.com/openjdk/jdk/blob/c05dc268acaf87236f30cf700ea3ac778e3b20e5/src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp#L1400-L1404
> 
> Seems like the code path is uncommon, but we should still fix it imho.
> 
> What do you think?

I haven't spotted the usage of r18 ( saving r18 on stack) in jdk17 with hsdis, hence I was thinking it's not affected and the fix is needed only in jdk11

-------------

PR: https://git.openjdk.java.net/jdk11u-dev/pull/301