Security fixes are back; other fixes can go in. Time for build 18?

[Kelly O'Hair]

Andrew John Hughes wrote:
> 2009/12/8 Kelly O'Hair <Kelly.Ohair at sun.com>:
>>
>> Jonathan Gibbons wrote:
>>> Andrew John Hughes wrote:
>>>>
>>>> Finally, during build, I just spotted another issue.  The langtools
>>>> build wrongly passes -Werror to javac and this has been removed in the
>>>> OpenJDK7 version.  It only shows up if you build OpenJDK6 with
>>>> OpenJDK7, so it's minor but probably worth fixing.  I doubt that is
>>>> the only building-with-7 issue though.
>> Building OpenJDK6  "with"  OpenJDK7?
>> You mean with an ALT_BOOTDIR=jdk7? Why?
>>
> 
> Why not? I happen to have a system install of OpenJDK7 m5 and not
> OpenJDK6 at present - the reason for that is exactly because you can't
> install 7 and then use it to build 6.  I've since been able to build
> OpenJDK6 using a recent build of IcedTea6 (which uses gcj to build).
> But surely 7 should be able to build 6?

I'm sure it can, and if told to behave like a jdk6 (e.g. -source 1.6 -target 1.6)
it should work in most cases.... I'm not sure we have ALL javac
compilations in the entire forest being explicit though, we should.

If ALT_BOOTDIR was only used to run the openjdk6 langtools javac, then
in theory it should work. But lots of other tools from ALT_BOOTDIR
are used, often getting default behaviors. Hotspot might end up building
the serviceability agent incorrectly (it uses ALT_BOOTDIR javac).
Not something I would trust working real well.

---
I'm a big fan of javac -Werror, I would hate to see that disabled anywhere.
If any team manages to get their java code warning free, using
-Werror is a great thing to do.

-kto

> 
>> -kto
>>
>>> langtools is supposed to be warning free and thus is supposed to use
>>> -Werror.
>>>
>>> -- Jon
> 
> 
>