Security fixes are back; other fixes can go in. Time for build 18?

[Andrew John Hughes]

2009/12/8 Kelly O'Hair <Kelly.Ohair at sun.com>:
>
>
> Andrew John Hughes wrote:
>>
>> 2009/12/8 Kelly O'Hair <Kelly.Ohair at sun.com>:
>>>
>>> Jonathan Gibbons wrote:
>>>>
>>>> Andrew John Hughes wrote:
>>>>>
>>>>> Finally, during build, I just spotted another issue.  The langtools
>>>>> build wrongly passes -Werror to javac and this has been removed in the
>>>>> OpenJDK7 version.  It only shows up if you build OpenJDK6 with
>>>>> OpenJDK7, so it's minor but probably worth fixing.  I doubt that is
>>>>> the only building-with-7 issue though.
>>>
>>> Building OpenJDK6  "with"  OpenJDK7?
>>> You mean with an ALT_BOOTDIR=jdk7? Why?
>>>
>>
>> Why not? I happen to have a system install of OpenJDK7 m5 and not
>> OpenJDK6 at present - the reason for that is exactly because you can't
>> install 7 and then use it to build 6.  I've since been able to build
>> OpenJDK6 using a recent build of IcedTea6 (which uses gcj to build).
>> But surely 7 should be able to build 6?
>
> I'm sure it can, and if told to behave like a jdk6 (e.g. -source 1.6 -target
> 1.6)
> it should work in most cases.... I'm not sure we have ALL javac
> compilations in the entire forest being explicit though, we should.
>
> If ALT_BOOTDIR was only used to run the openjdk6 langtools javac, then
> in theory it should work. But lots of other tools from ALT_BOOTDIR
> are used, often getting default behaviors. Hotspot might end up building
> the serviceability agent incorrectly (it uses ALT_BOOTDIR javac).
> Not something I would trust working real well.
>

Having happened to do this by chance, it does seem to be quite a good
testcase for these implicit assumptions.  The serviceability agent is
built with -1.4 FWIW.  I did some work making things explicit in
various repos. a while back but some of that might only be in 7.

> ---
> I'm a big fan of javac -Werror, I would hate to see that disabled anywhere.
> If any team manages to get their java code warning free, using
> -Werror is a great thing to do.
>

Same here.  I only suggested that because I thought that was the fix
applied to langtools thus far.  My mistake.

> -kto
>
>>
>>> -kto
>>>
>>>> langtools is supposed to be warning free and thus is supposed to use
>>>> -Werror.
>>>>
>>>> -- Jon
>>
>>
>>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8