[Fwd: code review round 0 for JVM/TI version fix (6849968) and phase assertion (6648438)]

[Daniel D. Daugherty]

I put the job in the JPRT-sfbay queue instead. There was a job
in the JPRT-HotSpotWest queue already... :-)

Dan


Daniel D. Daugherty wrote:
> Joseph D. Darcy wrote:
>> Dan,
>>
>> Assuming this has been reviewed and approved by the serviceability team,
>
> Since I'm the only one on Serviceability right now, I
> went for a more general review. :-)
>
> David Holmes and Kelly O'Hair both reviewed and approved.
>
> Dan
>
>> you're free to push this into the OpenJDK 6 repo.  The current build 
>> number to use is b18.
>
> Thanks. It will be in the JPRT-HotSpotWest queue shortly...
>
> Dan
>
>>
>> Thanks,
>>
>> -Joe
>>
>> Daniel D. Daugherty wrote:
>>> Joe,
>>>
>>> These fixes are ready to be pushed in OpenJDK6. I've already
>>> done the pushed into HSX-16.1 and HSX-17 (RT_Baseline).
>>>
>>> Please let me know if I can push these...
>>>
>>> Dan
>>>
>>>
>>> -------- Original Message --------
>>> Subject:     code review round 0 for JVM/TI version fix (6849968) 
>>> and phase assertion (6648438)
>>> Date:     Fri, 11 Dec 2009 15:52:38 -0700
>>> From:     Daniel D. Daugherty <Daniel.Daugherty at Sun.COM>
>>> Reply-To:     Daniel.Daugherty at Sun.COM
>>> To:     serviceability-dev at openjdk.java.net 
>>> <serviceability-dev at openjdk.java.net>, 
>>> serviceability-dev-confidential at sun.com
>>>
>>>
>>>
>>> Greetings,
>>>
>>> I have fixes for the following two JVM/TI bugs ready to go:
>>>
>>> 6648438 4/4 src/share/vm/prims/jvmtiEnv.cpp:457
>>>           assert(phase == JVMTI_PHASE_LIVE,"sanity check")
>>> 6849968 3/3 JVMTI tests fails on jdk5.0 with hs14
>>>
>>> 6849968 fixes a problem where JVM/TI version 1.0 semantics
>>> were not being used when that version was explicitly
>>> requested. I fixed 6648438 because it happened to be in the
>>> same place that I already had to tweak for 6849968. It also
>>> gets rid of an annoying intermittent fastdebug failure.
>>>
>>> Here is the webrev URL:
>>>
>>> http://cr.openjdk.java.net/~dcubed/batch-20091211-webrev/0/
>>>
>>> This webrev is relative to the OpenJDK6 version of the code.
>>> Once approved, these fixes will be pushed to:
>>>
>>> - OpenJDK6 (HSX-14-??)
>>> - JDK6-Update train (HSX-16-??)
>>> - OpenJDK7 (HSX-17-??)
>>>
>>> Comments, questions and suggestions are always welcome!
>>>
>>> Dan
>>>
>>>
>>