[7u4] Request for approval for CR 7088989 - Improve the performance for T4 by utilizing the newly provided crypto APIs

[Valerie (Yu-Ching) Peng]

Forgot to mention that I could move the tests out of OpenJDK if that'd 
help things .
And all will be done following the 7u public review process. ;)
Valerie

On 03/15/12 17:14, Valerie (Yu-Ching) Peng wrote:
>
> On 03/15/12 16:29, Andrew Hughes wrote:
>>>> 2.  Was there a reason the testcases in this commit were locked
>>>> down
>>>> to only work with the proprietary ucrypto provider?  Are they not
>>>> suitable for all providers?
>>>> They would be very useful for testing the SunPKCS11/NSS provider.
>>> That's a question better suited for the security-dev at openjdk list.
>>>
>> CCed.  As I said, I would have posted here first, if there had been a 
>> public review
>> of the patch to begin with.  There wasn't.
> The tests can be adapted to The testcases can be adapted to test other 
> providers. But since they are meant for Ucrypto provider, I coded them 
> to explicitly test against Ucrypto provider. Well, I thought some 
> people may want to run these tests if their build (or JDK releases) 
> contains Ucrypto provider. If build doesn't have Ucrypto provider, the 
> tests will silently pass, not affecting the overall result.
>
> Let me apologize again for accidentally broke the 7u putback guideline.
> Majority of the changes are under the closed part of JDK, thus it 
> didn't occur to me that I have to separate out the part that went into 
> OpenJDK for a public review. Learned the lesson the hard way as you 
> aren't the only one pointing this out.
> Regards,
> Valerie
>
>>
>> I noticed you don't seem to have commented on how this breaks the 
>> jdk7u guidelines.
>>
>>> cheers,
>>> dalibor topic
>>> -- 
>>> Oracle<http://www.oracle.com>
>>> Dalibor Topic | Principal Product Manager
>>> Phone: +494089091214<tel:+494089091214>  | Mobile: +491737185961
>>> <tel:+491737185961>
>>> Oracle Java Platform Group
>>>
>>> ORACLE Deutschland B.V.&  Co. KG | Nagelsweg 55 | 20097 Hamburg
>>>
>>> ORACLE Deutschland B.V.&  Co. KG
>>> Hauptverwaltung: Riesstr. 25, D-80992 München
>>> Registergericht: Amtsgericht München, HRA 95603
>>> Geschäftsführer: Jürgen Kunz
>>>
>>> Komplementärin: ORACLE Deutschland Verwaltung B.V.
>>> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
>>> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
>>> Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher
>>>
>>> Green Oracle<http://www.oracle.com/commitment>  Oracle is committed
>>> to developing practices and products that help protect the
>>> environment
>>>
>