Patch for audi/midi services <was> Re: Audio/Midi services <was> Fwd: CR 7172234 Created, P2 java/jigsaw Lot of sound test failed due UnsatisfiedLinkError for com.sun.media.sound.* classes

[Paul Sandoz]

On May 30, 2012, at 7:15 PM, Mandy Chung wrote:

> On 5/30/2012 7:41 AM, Paul Sandoz wrote:
>> It seems the pattern in jdk.depconfig is to always use optional, so i kept it like that, but since there are always services for the audi/midi cases, we don't need it to be optional, correct?
> 
> I scanned on javax.sound.midi.MidiSystem and looked at the javadoc for MidiSystem.getMidiDevice. It throws MidiUnavailableException if not available. It seems to me that these are optional services and JDK does ship its default.  It's fine to keep them as optional and we should confirm with the client team once they review the module-info.
> 

OK.


<snip>
>> + at Provider(optional)
>> +  javax.sound.sampled.spi.MixerProvider ->  META-INF/services/javax.sound.sampled.spi.MixerProvider
>> +
> 
> Looks good.  I will push this patch for you.

Thanks.


> Sorry for missing them and there may not have jdk regression tests uncovering this problem.
> 

No need to apologize! After routing around a little bit in the internals of the JDK i appreciate just how big this is collection of software is. Easy to miss stuff.


> There are two more service configuration files for JAXWS that are not listed in jdk.depconfig.  Do you mind taking a look at them and maybe already be covered in the JAXWS modularization effort?
> 

Will do.


> META-INF/services/com.sun.tools.internal.ws.wscompile.Plugin
> META-INF/services/com.sun.tools.internal.xjc.Plugin
> 

I did look at bit at these with the JAX-WS team. At the time we were unsure how the tooling would work with annotation processors (APs), so we left this are alone. Subsequently we checked that the jaxb/jax-ws tooling explicitly registered an AP so the tools should be OK in module mode.

I will double check with the JAX-WS team but i think we can declare these services in the jdk.tools.jaxws module. Later we will most likely need to separate into JAX-WS and JAXB tool modules.

Paul.