Patch for audi/midi services <was> Re: Audio/Midi services <was> Fwd: CR 7172234 Created, P2 java/jigsaw Lot of sound test failed due UnsatisfiedLinkError for com.sun.media.sound.* classes

[Artem Ananiev]

On 5/30/2012 9:15 PM, Mandy Chung wrote:
> On 5/30/2012 7:41 AM, Paul Sandoz wrote:
>> It seems the pattern in jdk.depconfig is to always use optional, so i
>> kept it like that, but since there are always services for the
>> audi/midi cases, we don't need it to be optional, correct?
>
> I scanned on javax.sound.midi.MidiSystem and looked at the javadoc for
> MidiSystem.getMidiDevice. It throws MidiUnavailableException if not
> available. It seems to me that these are optional services and JDK does
> ship its default. It's fine to keep them as optional and we should
> confirm with the client team once they review the module-info.

I'm just subscribed to this mailing list, and don't quite understand the 
patch, so my comments may look really lame... Right now JDK provides 
default implementations of some JavaSound services, but strictly 
speaking it's not forced by JavaSound APIs: there may be no service 
providers by default.

Thanks,

Artem

>> Paul.
>>
>> $ hg diff
>> diff -r 68564a2f4750 make/modules/jdk.depconfig
>> --- a/make/modules/jdk.depconfig Wed May 30 13:00:52 2012 +0100
>> +++ b/make/modules/jdk.depconfig Wed May 30 16:36:43 2012 +0200
>> @@ -542,3 +542,27 @@
>> @Provider(optional)
>> javax.xml.soap.SOAPFactory ->
>> META-INF/services/javax.xml.soap.SOAPFactory
>>
>> + at Provider(optional)
>> + javax.sound.midi.spi.MidiDeviceProvider ->
>> META-INF/services/javax.sound.midi.spi.MidiDeviceProvider
>> +
>> + at Provider(optional)
>> + javax.sound.midi.spi.MidiFileReader ->
>> META-INF/services/javax.sound.midi.spi.MidiFileReader
>> +
>> + at Provider(optional)
>> + javax.sound.midi.spi.MidiFileWriter ->
>> META-INF/services/javax.sound.midi.spi.MidiFileWriter
>> +
>> + at Provider(optional)
>> + javax.sound.midi.spi.SoundbankReader ->
>> META-INF/services/javax.sound.midi.spi.SoundbankReader
>> +
>> + at Provider(optional)
>> + javax.sound.sampled.spi.AudioFileReader ->
>> META-INF/services/javax.sound.sampled.spi.AudioFileReader
>> +
>> + at Provider(optional)
>> + javax.sound.sampled.spi.AudioFileWriter ->
>> META-INF/services/javax.sound.sampled.spi.AudioFileWriter
>> +
>> + at Provider(optional)
>> + javax.sound.sampled.spi.FormatConversionProvider ->
>> META-INF/services/javax.sound.sampled.spi.FormatConversionProvider
>> +
>> + at Provider(optional)
>> + javax.sound.sampled.spi.MixerProvider ->
>> META-INF/services/javax.sound.sampled.spi.MixerProvider
>> +
>
> Looks good. I will push this patch for you.Sorry for missing them and
> there may not have jdk regression tests uncovering this problem.
>
> There are two more service configuration files for JAXWS that are not
> listed in jdk.depconfig. Do you mind taking a look at them and maybe
> already be covered in the JAXWS modularization effort?
>
> META-INF/services/com.sun.tools.internal.ws.wscompile.Plugin
> META-INF/services/com.sun.tools.internal.xjc.Plugin
>
> Thanks
> Mandy