RFR: 8086: Some refactoring for jmc/core [v5]

[Brice Dutheil]

On Wed, 14 Jun 2023 07:38:43 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> I worked on some improvements/refactoring for jmc/core. In detail:
>> 
>> Better handling of Spotless and Checkstyle:
>>     - Fix calling spotless/checkstyle directly in submodules by refering to a `$jmc.config.path` variable
>>     - Integrate spotless into the regular build workflow
>> 
>> Cleanup of core/pom.xml:
>>     - URL cleanups
>>     - Plugin version bumps
>> 
>> Lighter test projects:
>>     - They don't need to be p2 plugin projects since they only test basic functionality but not in the context of Eclipse/OSGI modules
>>     - Disable some maven plugin executions that are not needed there
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Don't touch checkformatting scripts in this change

Looks good to me there's a nitpick about the usage of property in the javadoc plugin configuration

core/pom.xml line 295:

> 293: 						<goals>
> 294: 							<goal>check</goal>
> 295: 						</goals>

**thought (non-blocking):** Have you ever thought about making the style checks before compilation ?

Since style is faster to fix than the whole compilation this could avoid awaiting long PR pre-submit feedback to fix these.

core/pom.xml line 404:

> 402: 				</executions>
> 403: 				<configuration>
> 404: 					<release>17</release>

**suggestion:** Good catch, I think you could use the property instead :

Suggestion:

					<release>${maven.compiler.source}</release>

-------------

Marked as reviewed by bdutheil (Author).

PR Review: https://git.openjdk.org/jmc/pull/495#pullrequestreview-1478893279
PR Review Comment: https://git.openjdk.org/jmc/pull/495#discussion_r1229299641
PR Review Comment: https://git.openjdk.org/jmc/pull/495#discussion_r1229268555