RFR: 8086: Some refactoring for jmc/core [v5]
Brice Dutheil
bdutheil at openjdk.org
Wed Jun 14 09:43:09 UTC 2023
On Wed, 14 Jun 2023 09:03:47 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:
>> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Don't touch checkformatting scripts in this change
>
> core/pom.xml line 404:
>
>> 402: </executions>
>> 403: <configuration>
>> 404: <release>17</release>
>
> **suggestion:** Good catch, I think you could use the property instead :
>
> Suggestion:
>
> <release>${maven.compiler.source}</release>
Or maybe (and then creating necessary properties)
Suggestion:
<source>${maven.javadoc.source}</source>
<release>${maven.javadoc.release}</release>
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/495#discussion_r1229318543
More information about the jmc-dev
mailing list