RFR: 8086: Some refactoring for jmc/core [v5]

Christoph Langer clanger at openjdk.org
Wed Jun 14 10:22:09 UTC 2023


On Wed, 14 Jun 2023 09:39:58 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> core/pom.xml line 404:
>> 
>>> 402: 				</executions>
>>> 403: 				<configuration>
>>> 404: 					<release>17</release>
>> 
>> **suggestion:** Good catch, I think you could use the property instead :
>> 
>> Suggestion:
>> 
>> 					<release>${maven.compiler.source}</release>
>
> Or maybe (and then creating necessary properties) 
> 
> Suggestion:
> 
> <source>${maven.javadoc.source}</source>
> <release>${maven.javadoc.release}</release>

Good point, I will resort to maven.compiler.source, think that makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/495#discussion_r1229362623


More information about the jmc-dev mailing list