RFR: 8086: Some refactoring for jmc/core [v5]
Christoph Langer
clanger at openjdk.org
Wed Jun 14 10:22:08 UTC 2023
On Wed, 14 Jun 2023 09:25:22 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:
>> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Don't touch checkformatting scripts in this change
>
> core/pom.xml line 295:
>
>> 293: <goals>
>> 294: <goal>check</goal>
>> 295: </goals>
>
> **thought (non-blocking):** Have you ever thought about making the style checks before compilation ?
>
> Since style is faster to fix than the whole compilation this could avoid awaiting long PR pre-submit feedback to fix these.
That's what happens now. spotless:check is run during validate phase now. Far before compilation.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/495#discussion_r1229361644
More information about the jmc-dev
mailing list