RFR: 8055: Improvement in stacktrace view for Duration [v2]

Suchita Chaturvedi schaturvedi at openjdk.org
Sun May 21 10:41:20 UTC 2023


On Fri, 19 May 2023 17:50:08 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unused method
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 919:
> 
>> 917: 				return UnitLookup.PERCENT_UNITY.quantity(duration.doubleValue() / (double) totalDuration.doubleValue())
>> 918: 						.displayUsing(IDisplayable.AUTO);
>> 919: 			} else
> 
> Style nit: Please also use braces for the else part.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1199740077


More information about the jmc-dev mailing list