Review request for JDK-8007286: Add JavaAdapter and importPackage to compatibility script
Marcus Lagergren
marcus.lagergren at oracle.com
Thu Jan 31 05:36:27 PST 2013
Looks good.
Convention question:
+ protected static final String engineScriptSourceName = "nashorn:engine/resources/engine.js";
All other static final variables in Nashorn seem to be named in caps, so maybe it should be ENGINE_SCRIPT_SOURCE_NAME for consistency?
/M
On Jan 31, 2013, at 2:25 PM, A. Sundararajan <sundararajan.athijegannathan at oracle.com> wrote:
> Please review http://cr.openjdk.java.net/~sundar/8007286/
>
> Thanks
> -Sundar
More information about the nashorn-dev
mailing list