Review request for JDK-8007286: Add JavaAdapter and importPackage to compatibility script
A. Sundararajan
sundararajan.athijegannathan at oracle.com
Thu Jan 31 05:35:39 PST 2013
Okay, I'll make that change to be consistent.
Thanks
-Sundar
On Thursday 31 January 2013 07:06 PM, Marcus Lagergren wrote:
> Looks good.
>
> Convention question:
>
> + protected static final String engineScriptSourceName = "nashorn:engine/resources/engine.js";
>
> All other static final variables in Nashorn seem to be named in caps,
> so maybe it should be ENGINE_SCRIPT_SOURCE_NAME for consistency?
>
> /M
>
> On Jan 31, 2013, at 2:25 PM, A. Sundararajan
> <sundararajan.athijegannathan at oracle.com
> <mailto:sundararajan.athijegannathan at oracle.com>> wrote:
>
>> Please review http://cr.openjdk.java.net/~sundar/8007286/
>> <http://cr.openjdk.java.net/%7Esundar/8007286/>
>>
>> Thanks
>> -Sundar
>
More information about the nashorn-dev
mailing list