RFR: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659 [v3]

[Daniel Jeliński]

On Mon, 20 Mar 2023 19:00:49 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use NetworkConfiguration
>
> test/jdk/java/net/SocketOption/options.policy line 34:
> 
>> 32: };
>> 33: // for JTwork/classes/test/lib/jdk/test/lib/NetworkConfiguration.class
>> 34: grant codeBase "file:${test.classes}/../../../../test/lib/-" {
> 
> A single grant clause with the two permissions should be enough - since both classes are in the same codebase. Also I thought the plan was to grant `SocketPermission "*:*" ...` to the test? If so then you could simply add the two permissions to the global grant clause. No need to distinguish between the permissions granted to the library and the permissions granted to the test.

I modeled this after other tests which explicitly grant permissions to the library code. But you're right, we don't need to distinguish between these permissions; the SM test was introduced by JDK-8245828, and the new permissions will not interfere with its original purpose.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13061#discussion_r1143086422