[REVIEW REQUEST] Add text property to ComboBox

[Werner Lehmann]

Fully agree with this. The common usecase by far are strings, and 
ColorComboboxes etc. could still extend ComboBoxBase.

In my opinion it should not be necessary to lookup control internals - 
might be ok as a temporary workaround but not in the long run. This 
lookup will also break encapsulation but in a more contrived way.

As to exposing TextField or TextInputControl: the latter would make 
sense only if TextArea was also an option, right? That would probably 
require a different skin. Correct me if I am wrong but that also sounds 
like requiring another control using such a TextArea based skin. If that 
is true than nothing is lost by exposing TextField on ComboBox. Also, I 
have never seen a multiline text combobox - can't be very common.

Rgds
Werner

On 18.04.2012 02:30, Jonathan Giles wrote:
> What are peoples thoughts? Can we wrap this one up by simply exposing
> the TextField/TextInputControl, or are there concerns with this? Also,
> if we are to expose one, I'm tempted to expose TextField rather than
> TextInputControl...