[REVIEW REQUEST] Add text property to ComboBox

[Jonathan Giles]

After all the discussion on adding text / textfield / textInputControl 
properties to ComboBox, there is still no clear winner. My gut feeling 
is to not expose TextField / TextInputControl directly to the user. 
However, my main driver for getting this done is for the Scene Builder 
team, who want access to the entire TextInputControl (and realistically, 
the TextField itself).

Ideally, I could postpone this past JavaFX 2.2 so there was more time 
for consideration, but realistically I think we're at a point where we 
just need to make a decision and move on.

Therefore, ignoring my gut feeling and being pragmatic about this 
request, I will give 24 hours notice that my intention is to expose the 
TextField itself in the ComboBox control. If there are any strong 
objections, please let them be known (even if you've registered an 
objection already). If I don't hear any strong objections, I will assume 
an implicit approval has been given.

-- Jonathan


On 18/04/2012 9:32 p.m., Werner Lehmann wrote:
> Fully agree with this. The common usecase by far are strings, and 
> ColorComboboxes etc. could still extend ComboBoxBase.
>
> In my opinion it should not be necessary to lookup control internals - 
> might be ok as a temporary workaround but not in the long run. This 
> lookup will also break encapsulation but in a more contrived way.
>
> As to exposing TextField or TextInputControl: the latter would make 
> sense only if TextArea was also an option, right? That would probably 
> require a different skin. Correct me if I am wrong but that also 
> sounds like requiring another control using such a TextArea based 
> skin. If that is true than nothing is lost by exposing TextField on 
> ComboBox. Also, I have never seen a multiline text combobox - can't be 
> very common.
>
> Rgds
> Werner
>
> On 18.04.2012 02:30, Jonathan Giles wrote:
>> What are peoples thoughts? Can we wrap this one up by simply exposing
>> the TextField/TextInputControl, or are there concerns with this? Also,
>> if we are to expose one, I'm tempted to expose TextField rather than
>> TextInputControl...