RFR: 8272118: ListViewSkin et al: must not cancel edit on scrolling

Ajit Ghaisas aghaisas at openjdk.java.net
Wed Dec 1 11:45:29 UTC 2021


On Thu, 25 Nov 2021 15:46:01 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Issue was that mouse pressed on the scrollbars of all virtualized controls cancelled the edit. That's inconsistent with other scroll triggers (mouseWheel, programmatic). Fixed by removing the cancel.
> 
> Added tests that failed/passed before/after the fix. Also added tests that passed both before/after to guarantee that required functionality of the mouse pressed (= requesting focus on the control if needed) is still working.

Looks good to me.

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/682


More information about the openjfx-dev mailing list