[jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

Nir Lisker nlisker at openjdk.java.net
Fri Feb 4 18:26:57 UTC 2022


> Now that the standard concrete light types were added, there is an opportunity to rearrange and rewrite some of the class docs. Here is a summary of the changes:
> 
> * Moved the explanations of attenuation and direction up to `LightBase` since different light types share characteristics. `LightBase` now contains a summary of its subtypes and all the explanations of the properties/characteristics of the lights divided into sections: Color, Scope, Direction, Attenuation.
> * Each light type links to the relevant section in `LightBase` when it mentioned the properties it has.
> * Added examples of real-world applications for each light type.
> * Consolidated the writing style for all the subclasses.

Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:

  Changed description of ambient light

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/717/files
  - new: https://git.openjdk.java.net/jfx/pull/717/files/cae874d6..987a6165

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=717&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=717&range=03-04

  Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jfx/pull/717.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/717/head:pull/717

PR: https://git.openjdk.java.net/jfx/pull/717


More information about the openjfx-dev mailing list