RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v3]
John Hendrikx
jhendrikx at openjdk.org
Tue Nov 22 19:00:23 UTC 2022
On Tue, 22 Nov 2022 18:41:18 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert changes to javafx.web src/main/native
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>
>> 1444: @Override
>> 1445: public void processEndElement() throws IOException {
>> 1446: super.processEndElement();
>
> I don't see a warning for it, What setting warns about calling an empty method?
The `processEndElement` in the base class was an empty method that throws `IOException`. By making it `abstract` the warning is avoided, but this means the call to `super` here is no longer relevant (it wasn't relevant anyway as the base method was empty).
-------------
PR: https://git.openjdk.org/jfx/pull/958
More information about the openjfx-dev
mailing list