RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]

Tue Aug 8 17:39:22 UTC 2023

On Tue, 8 Aug 2023 16:39:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   clean up according to review comments
>
> modules/javafx.web/src/main/native/Source/WebCore/platform/java/ModernMediaControlResource.cpp line 28:
> 
>> 26: #include "ModernMediaControlResource.h"
>> 27: 
>> 28: ModernMediaControlResource::ModernMediaControlResource() {
> 
> Can you add a comment indicating that the Base64 images in this file were generated from the resources in `WebCore/Modules/modern-media-controls/images/adwaita/` using the `Tools/Scripts/generate_icon_resource.py` script?

done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1201#discussion_r1287448895