RFR: 8250802: Refactor StringConverter and its subclasses [v2]
Nir Lisker
nlisker at openjdk.org
Wed Nov 19 00:08:46 UTC 2025
On Tue, 18 Nov 2025 00:00:14 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> modules/javafx.base/src/main/java/javafx/util/converter/BaseStringConverter.java line 30:
>>
>>> 28: import javafx.util.StringConverter;
>>> 29:
>>> 30: /// A base class containing common implementations for `StringConverter`s as noted in the @implNote of `StringConverter`.
>>
>> In light of possible backporting, it's been decided earlier not to use markdown comments.
>
> In general, yes, but I note that this is a pretty major refactoring where most of the javadocs were redone, and all of them now use markdown. This is a case where we could consider allowing them. I don't have a strong opinion either way, and likely won't have time to review this one for a while...
> In light of possible backporting, it's been decided earlier not to use markdown comments.
On the mailing list it was suggested to allow them in this PR (and revert them in the PR for adding the MOUSE_DRAG_DONE event).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2540003224
More information about the openjfx-dev
mailing list