RFR: 8250802: Refactor StringConverter and its subclasses [v2]
Kevin Rushforth
kcr at openjdk.org
Wed Nov 19 00:18:55 UTC 2025
On Wed, 19 Nov 2025 00:06:37 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> In general, yes, but I note that this is a pretty major refactoring where most of the javadocs were redone, and all of them now use markdown. This is a case where we could consider allowing them. I don't have a strong opinion either way, and likely won't have time to review this one for a while...
>
>> In light of possible backporting, it's been decided earlier not to use markdown comments.
>
> On the mailing list it was suggested to allow them in this PR (and revert them in the PR for adding the MOUSE_DRAG_DONE event).
Yes, that was what I had suggested earlier. As I mentioned above I think this is one case where using markdown comments seems reasonable.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2540019286
More information about the openjfx-dev
mailing list