[riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux [v3]

Yanhong Zhu yzhu at openjdk.java.net
Fri Nov 19 04:57:48 UTC 2021


On Fri, 19 Nov 2021 04:01:14 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   keep extension order same as HWCAP_ISA
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 44:
> 
>> 42: 
>> 43:   enum Feature_Flag {
>> 44: #define CPU_FEATURE_FLAGS(decl)               \
> 
> Please keep those macros in the same order as the HWCAP_ISA_X macros in file vm_version_linux_riscv.cpp.

fixed

> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 100:
> 
>> 98:       HWCAP_ISA_I |
>> 99:       HWCAP_ISA_M |
>> 100:       HWCAP_ISA_V);
> 
> Please also add checking for 'B' and 'C' here.

done

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/10


More information about the riscv-port-dev mailing list