[riscv-port] Integrated: 8281731: riscv: Refactor instruction extraction code in nativeInst_riscv.h/cpp

Xiaolin Zheng xlinzheng at openjdk.java.net
Wed Feb 16 07:18:32 UTC 2022


On Mon, 14 Feb 2022 10:29:13 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> Hi team,
> 
> Could I have a review of this patch - this is just a trivial refactoring with some cleanups for `nativeInst_riscv.h/cpp` using `Assembler::extract()` with raw bits, by adding `extract_rs1`, `extract_rs2`, `extract_rd`, `extract_opcode`, and `extract_funct3` to make the code cleaner and conciser. Tested hotspot tier1 on Qemu with no other errors found.
> 
> Thanks,
> Xiaolin

This pull request has now been integrated.

Changeset: 78b452d4
Author:    Xiaolin Zheng <xlinzheng at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.java.net/riscv-port/commit/78b452d485d6a87c143fc5407ac48ea05e417c2f
Stats:     155 lines in 2 files changed: 49 ins; 21 del; 85 mod

8281731: riscv: Refactor instruction extraction code in nativeInst_riscv.h/cpp

Reviewed-by: yadongwang, fyang

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/57


More information about the riscv-port-dev mailing list