[riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v2]

Xiaolin Zheng xlinzheng at openjdk.java.net
Fri Jan 21 03:14:37 UTC 2022


On Fri, 21 Jan 2022 03:01:43 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Polish comments
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 63:
> 
>> 61: 
>> 62:   void leave() {
>> 63:     // Note: setting sp above the address of alive variables could result in undefined behaviors:
> 
> I would suggest move this code comment before function "void enter()" in the same file.
> Maybe rephrasing like this:
> "SP must be updated to the right place before saving/restoring RA and FP because signal
>  based thread suspend/resume could happen asynchronously."

Thanks for the suggestion, changed.

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/49


More information about the riscv-port-dev mailing list