[riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v2]

[Fei Yang]

On Fri, 21 Jan 2022 03:09:30 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 63:
>> 
>>> 61: 
>>> 62:   void leave() {
>>> 63:     // Note: setting sp above the address of alive variables could result in undefined behaviors:
>> 
>> I would suggest move this code comment before function "void enter()" in the same file.
>> Maybe rephrasing like this:
>> "SP must be updated to the right place before saving/restoring RA and FP because signal
>>  based thread suspend/resume could happen asynchronously."
>
> Thanks for the suggestion, changed.

I think it's better to go like this:

  // Stack frame creation/removal
  // Note that SP must be updated to the right place before saving/restoring RA and FP
  // because signal based thread suspend/resume could happen asynchronously.

-------------

PR: https://git.openjdk.java.net/riscv-port/pull/49