[security-dev 01424]: Re: Please review patch for regression test sun/security/tools/keytool/StartDate

Andrew John Hughes gnu_andrew at member.fsf.org
Thu Dec 3 16:28:57 UTC 2009


2009/12/3 Pavel Tisnovsky <ptisnovs at redhat.com>:
> Hi,
>
> patch for regression test sun/security/tools/keytool/StartDate.java
> (included in OpenJDK6) is exposed at
>
> http://cr.openjdk.java.net/~ptisnovs/StartDateTest/
>
> and prepared for review.
>
> This patch ensures, that this test does not fail on December(s) due to
> incorrect comparison of two months (12 != 0).
>
> Can you please review and possibly approve this patch?
>
> Pavel Tisnovsky
> Red Hat
>

This looks sane to me, and indeed the fix has already been applied in OpenJDK7:

http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/2c37083730b1

Joe, can we please backport this to OpenJDK6?
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the security-dev mailing list