[security-dev 01426]: Re: Please review patch for regression test sun/security/tools/keytool/StartDate

Joe Darcy Joe.Darcy at Sun.COM
Thu Dec 3 21:48:10 UTC 2009


Andrew John Hughes wrote:
> 2009/12/3 Pavel Tisnovsky <ptisnovs at redhat.com>:
>   
>> Hi,
>>
>> patch for regression test sun/security/tools/keytool/StartDate.java
>> (included in OpenJDK6) is exposed at
>>
>> http://cr.openjdk.java.net/~ptisnovs/StartDateTest/
>>
>> and prepared for review.
>>
>> This patch ensures, that this test does not fail on December(s) due to
>> incorrect comparison of two months (12 != 0).
>>
>> Can you please review and possibly approve this patch?
>>
>> Pavel Tisnovsky
>> Red Hat
>>
>>     
>
> This looks sane to me, and indeed the fix has already been applied in OpenJDK7:
>
> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/2c37083730b1
>
> Joe, can we please backport this to OpenJDK6?
> --
>   

Certainly!

Thanks,

-Joe



More information about the security-dev mailing list