[security-dev 01429]: Re: Please review patch for regression test sun/security/tools/keytool/StartDate

[Max (Weijun) Wang]

Hi Joe

I'll backport the fix to openjdk-6.

In fact, I haven't made any changes to openjdk-6 except for SSR  
releases. Just browse hg.openjdk.java.net and find only one openjdk-6  
entrance:

    http://hg.openjdk.java.net/jdk6/jdk6-gate/jdk/

So there's no sub repo for different groups and this is the one I  
should putback to?

Do I need to use JPRT to putback the fix or I can simply "hg push"? I  
remember JPRT was needed when the repo was initialized some time ago.

Thanks
Max

On Dec 4, 2009, at 5:48 AM, Joe Darcy wrote:

> Andrew John Hughes wrote:
>> 2009/12/3 Pavel Tisnovsky <ptisnovs at redhat.com>:
>>
>>> Hi,
>>>
>>> patch for regression test sun/security/tools/keytool/StartDate.java
>>> (included in OpenJDK6) is exposed at
>>>
>>> http://cr.openjdk.java.net/~ptisnovs/StartDateTest/
>>>
>>> and prepared for review.
>>>
>>> This patch ensures, that this test does not fail on December(s)  
>>> due to
>>> incorrect comparison of two months (12 != 0).
>>>
>>> Can you please review and possibly approve this patch?
>>>
>>> Pavel Tisnovsky
>>> Red Hat
>>>
>>>
>>
>> This looks sane to me, and indeed the fix has already been applied  
>> in OpenJDK7:
>>
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/2c37083730b1
>>
>> Joe, can we please backport this to OpenJDK6?
>> --
>>
>
> Certainly!
>
> Thanks,
>
> -Joe