review request for 7008713: diamond conversion of kerberos5 and security tools

Brad Wetmore bradford.wetmore at oracle.com
Wed Dec 22 18:19:53 PST 2010


> Using the diamond operator definitely makes the code *shorter*. Whether
> it's *better* doesn't necessarily follow from that. In most cases,
> though, using diamond is better, I think.
>
> I'd be curious if you saw any instances where you thought that it would
> be better not to use diamond. It's not a requirement to use diamond
> everywhere possible. That's one of the points of this exercise, which is
> to put the new language features through their paces on real code, and
> to see how well it works out.

Ok, with this answer, the question I asked earlier could potentially 
apply.  The change made it a little more confusing to me.

Brad




More information about the security-dev mailing list