review request for 7008713: diamond conversion of kerberos5 and security tools

Brad Wetmore bradford.wetmore at
Thu Dec 23 18:02:05 PST 2010

On 12/23/2010 11:42 AM, Stuart Marks wrote:
> On 12/22/10 6:19 PM, Brad Wetmore wrote:
>>> Using the diamond operator definitely makes the code *shorter*. Whether
>>> it's *better* doesn't necessarily follow from that. In most cases,
>>> though, using diamond is better, I think.
>>> I'd be curious if you saw any instances where you thought that it would
>>> be better not to use diamond. It's not a requirement to use diamond
>>> everywhere possible. That's one of the points of this exercise, which is
>>> to put the new language features through their paces on real code, and
>>> to see how well it works out.
>> Ok, with this answer, the question I asked earlier could potentially
>> apply. The
>> change made it a little more confusing to me.
>> Brad
> Hi Brad,
> Did you have any issues with 7008713, or can I just go ahead and push
> it?

kerberos5 and the tools would be Max's domain.  I wasn't planning to 
review unless you need a second reviewer.


More information about the security-dev mailing list