2nd round code review request: 7055363: jdk_security3 cleanup

Weijun Wang weijun.wang at oracle.com
Tue Aug 2 07:02:33 UTC 2011


Hi All

http://cr.openjdk.java.net/~weijun/7055363/webrev.01/

*Attention*: please note that the jtreg mode for jdk_security3 is still 
RunOthervmBatch. Xuelei is now working on the JSSE tests. Once he is 
ready, he will change the mode to RunSamevmBatch.

The code changes:

* Still included in test/ProblemList.txt

- JSSE tests, Xuelei is working on them
- ec tests on solaris-i586, they fail even if run standalone

* PKCS11/EC tests:

- New Providers.setAt, to ensure provider is added to desired position:
     test/sun/security/pkcs11/ec/*

- PKCS11Test.safeReload, to ensure shared library can be loaded again:
     test/sun/security/pkcs11/PKCS11Test.java
     test/sun/security/pkcs11/SecmodTest.java

- Test using config files need to run in othervm:
     test/sun/security/pkcs11/Secmod/*
     test/sun/security/pkcs11/fips/*

- Restoring provider lists:
     test/sun/security/ec/TestEC.java
     test/sun/security/pkcs11/PKCS11Test.java

* Try-with-resources updates:

- test/com/sun/security/auth/login/ConfigFile/IllegalURL.java
- test/sun/security/pkcs12/PKCS12SameKeyId.java
- test/sun/security/tools/keytool/StartDateTest.java

* Other tests still need to be in -othervm:

   Using special policy file:
     test/sun/security/provider/PolicyFile/Comparator.java
   AlgorithmId static field oidTable initialization:
     test/sun/security/x509/AlgorithmId/ExtensibleAlgorithmId.java

* JAAS configuration restore:

- test/javax/security/auth/login/LoginContext/ResetConfigModule.java

* Use "localhost" as hostname, to make name resolution fast

- test/sun/security/jgss/spnego/NoSpnegoAsDefMech.java


After these changes, JPRT test run (with RunSamevmBatch and no JSSE 
tests) shows most tests are OK. There are still intermittent failures 
which are PKCS11/EC provider related.

Thanks
Max



More information about the security-dev mailing list