2nd round code review request: 7055363: jdk_security3 cleanup

Alan Bateman Alan.Bateman at oracle.com
Tue Aug 2 09:43:19 PDT 2011


Weijun Wang wrote:
> Hi All
>
> http://cr.openjdk.java.net/~weijun/7055363/webrev.01/
I went through the changes to the tests and they look okay to me. It's 
good to see so many tests removed from the problem list and the tests 
updated to work in samevm or agentvm mode.

Is there a bug created for the ec tests that are failing on 
solaris-i586? If so then it would be good to include the bugID for 
future edits to the problem list. Also I see you've commented out two ec 
tests and I wonder if these lines should be removed or uncommented.

test/com/sun/security/auth/login/ConfigFile/IllegalURL.java - no problem 
with your change but I notice this test using URL's getFile which isn't 
the right way to get to a file path. Could this be changed to using 
File(URI)?

-Alan.








More information about the security-dev mailing list