Code review request for 6839886, 7033170, 7084025

Sean Mullan sean.mullan at oracle.com
Wed Dec 21 19:15:00 UTC 2011


On 12/20/11 6:08 PM, Valerie (Yu-Ching) Peng wrote:
> Sean,
> 
> Can you please help reviewing the fixes for
> 
> 6839886: Array overrun in pkcs11
> http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/
> (fixed to use the correct value; no regression test due to @reg-hard)

Looks fine.

> 7033170: Cipher.getMaxAllowedKeyLength(String) throws 
> NoSuchAlgorithmException
> http://cr.openjdk.java.net/~valeriep/7033170/webrev.00/
> (changed to always use the full transformation string)

Looks fine.

> 7084025: closed/sun/security/rsa/TestLimits.java doesn't compile on Windows
> http://cr.openjdk.java.net/~valeriep/7084025/webrev.00/
> (No SunPKCS11 classes on windows 64-bit, so changed to use reflection)

Shouldn't you remove the entry from closed/ProblemList now that the test is fixed?

--Sean



More information about the security-dev mailing list