Code review request for 6839886, 7033170, 7084025

[Valerie (Yu-Ching) Peng]

Sean,

Thanks for the review!
I didn't update the ProblemList due to another bug 6975859.
Will have to fix that before we remove the entry the ProblemList.

Valerie

On 12/21/11 11:15, Sean Mullan wrote:
> On 12/20/11 6:08 PM, Valerie (Yu-Ching) Peng wrote:
>   
>> Sean,
>>
>> Can you please help reviewing the fixes for
>>
>> 6839886: Array overrun in pkcs11
>> http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/
>> (fixed to use the correct value; no regression test due to @reg-hard)
>>     
>
> Looks fine.
>
>   
>> 7033170: Cipher.getMaxAllowedKeyLength(String) throws 
>> NoSuchAlgorithmException
>> http://cr.openjdk.java.net/~valeriep/7033170/webrev.00/
>> (changed to always use the full transformation string)
>>     
>
> Looks fine.
>
>   
>> 7084025: closed/sun/security/rsa/TestLimits.java doesn't compile on Windows
>> http://cr.openjdk.java.net/~valeriep/7084025/webrev.00/
>> (No SunPKCS11 classes on windows 64-bit, so changed to use reflection)
>>     
>
> Shouldn't you remove the entry from closed/ProblemList now that the test is fixed?
>
> --Sean
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20111221/9ac97806/attachment.htm>