Code Review Request for 7044443/100142

Alan Bateman Alan.Bateman at oracle.com
Fri May 20 02:13:27 PDT 2011


Sean Mullan wrote:
> Chris or Alan,
>
> Since both of you have been helping with this regression, could one or 
> both of you review the fix for:
>
> https://bugs.openjdk.java.net/show_bug.cgi?id=100142
>
> The fix is similar, but slightly different than the patch that was 
> submitted.
>
> webrev: http://cr.openjdk.java.net/~mullan/webrevs/7044443/webrev.00/
>
> Omair,
>
> Could you also test the patch?
>
> Thanks,
> Sean
The changes looks okay to me and good to have a test included. I guess 
technically the scheme should be compared without regards to case but I 
see the existing code also uses equals.

-Alan.




More information about the security-dev mailing list