Code Review Request for 7044443/100142

Chris Hegarty chris.hegarty at oracle.com
Fri May 20 03:45:20 PDT 2011


On 05/20/11 10:13 AM, Alan Bateman wrote:
> Sean Mullan wrote:
>> Chris or Alan,
>>
>> Since both of you have been helping with this regression, could one or
>> both of you review the fix for:
>>
>> https://bugs.openjdk.java.net/show_bug.cgi?id=100142
>>
>> The fix is similar, but slightly different than the patch that was
>> submitted.
>>
>> webrev: http://cr.openjdk.java.net/~mullan/webrevs/7044443/webrev.00/
>>
>> Omair,
>>
>> Could you also test the patch?
>>
>> Thanks,
>> Sean
> The changes looks okay to me and good to have a test included. I guess
> technically the scheme should be compared without regards to case but I
> see the existing code also uses equals.

The changes look good to me too.

One minor comment on line 1800 of the new file. 'separator++' should be 
just 'separator', the increment operator is not required ( and may be a 
little misleading ).

-Chris.

>
> -Alan.
>



More information about the security-dev mailing list